Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Bootstrap 4 #234

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

WIP: Bootstrap 4 #234

wants to merge 1 commit into from

Conversation

viktorsmari
Copy link
Member

@viktorsmari viktorsmari commented Sep 4, 2019

Migration guide

https://getbootstrap.com/docs/4.0/migration/

TODO:

  • form-group needs to become form-group row in: http://localhost:8000/accounts/settings/
  • Do we need this: django-bootstrap-form==3.4 ? We already have django-crispy-forms. REMOVED.
  • Re-generate .map files.
  • Update the django-crispy-forms and django-bootstrap-form to the latest?

@viktorsmari viktorsmari requested a review from helgihg September 5, 2019 07:52
@tomage
Copy link

tomage commented May 29, 2022

You wanna resolve the conflicts, and look over that last TODO item @viktorsmari ? Then we can discuss merging in and deploying to prod, be it before/after the blackification of the codebase.

@tomage tomage marked this pull request as draft May 29, 2022 23:15
@tomage
Copy link

tomage commented May 29, 2022

Also: Just converted to a Draft PR, since it's WIP ;)

Updated after a long pause by Tómas Árni Jónasson <[email protected]>.
@viktorsmari viktorsmari marked this pull request as ready for review June 1, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants