Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ranked OR TAAT #73

Merged
merged 30 commits into from
Jan 21, 2019
Merged

Ranked OR TAAT #73

merged 30 commits into from
Jan 21, 2019

Conversation

amallia
Copy link
Member

@amallia amallia commented Jan 21, 2019

Since #14 was getting more complicated, I thought it was better to first merge this.

We will squash everything before merging, but basically it includes:

  • ranked OR taat
  • simple accumulator
  • general refactoring of query algorithms

MaxScore and other accumulators will be addressed separately.

@amallia amallia requested a review from elshize January 21, 2019 12:40
@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #73 into master will increase coverage by 0.05%.
The diff coverage is 98.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   92.57%   92.62%   +0.05%     
==========================================
  Files          85       87       +2     
  Lines        4914     4961      +47     
==========================================
+ Hits         4549     4595      +46     
- Misses        365      366       +1
Impacted Files Coverage Δ
include/pisa/freq_index.hpp 100% <ø> (ø) ⬆️
include/pisa/block_posting_list.hpp 98.54% <ø> (ø) ⬆️
include/pisa/query/algorithm/ranked_or_query.hpp 97.29% <100%> (+0.07%) ⬆️
include/pisa/query/algorithm/wand_query.hpp 98.41% <100%> (+0.02%) ⬆️
...lude/pisa/query/algorithm/block_max_wand_query.hpp 99.03% <100%> (ø) ⬆️
include/pisa/query/algorithm/maxscore_query.hpp 98.38% <100%> (ø) ⬆️
.../pisa/query/algorithm/block_max_maxscore_query.hpp 98.68% <100%> (+0.01%) ⬆️
test/test_ranked_queries.cpp 100% <100%> (ø) ⬆️
include/pisa/accumulator/simple_accumulator.hpp 100% <100%> (ø)
test/test_bmw_queries.cpp 100% <100%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe849bb...56ecfc6. Read the comment docs.

@amallia amallia merged commit 790b7bd into master Jan 21, 2019
@amallia amallia deleted the ranked_or_taat branch January 21, 2019 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants