Skip to content

Bump rubyzip dependency to 3#1063

Open
eqladios wants to merge 1 commit into
pivotal:masterfrom
eqladios:chore/bump-rubyzip-dependency-to-3
Open

Bump rubyzip dependency to 3#1063
eqladios wants to merge 1 commit into
pivotal:masterfrom
eqladios:chore/bump-rubyzip-dependency-to-3

Conversation

@eqladios

@eqladios eqladios commented Aug 23, 2025

Copy link
Copy Markdown
  • updated call for Zip::File#open in nuget_spec to use named arguments, should still work fine with <3
  • all of the current calls to RubyZip API should work without issues with version >=3, <4
  • tests pass successfully

changes:

  • bump rubyzip dependency to 3
  • update license_finder.gemspec
  • update call for Zip::File#open at nuget spec to use named arguments
  • no other changes needed to calls for original rubyzip API

@eqladios eqladios marked this pull request as draft August 23, 2025 18:18
@eqladios eqladios force-pushed the chore/bump-rubyzip-dependency-to-3 branch from d126d8b to 3c004d1 Compare August 23, 2025 18:34
- bump rubyzip dependency to 3
- update license_finder.gemspec
- update call for Zip::File#open at nuget spec to use named arguments
- no other changes needed to calls for original rubyzip API
@eqladios eqladios force-pushed the chore/bump-rubyzip-dependency-to-3 branch from 3c004d1 to 2117ed5 Compare August 23, 2025 18:49
@eqladios eqladios marked this pull request as ready for review August 23, 2025 18:52
@david-a-wheeler

Copy link
Copy Markdown

+1 !

Thanks, I'm a happy user of license_finder but its configuration is currently keeping me from updating rubyzip.

This would solve it! Danke!

@adfoster-r7 adfoster-r7 mentioned this pull request Oct 2, 2025
@adfoster-r7

Copy link
Copy Markdown

Also hitting this, thanks for the PR!

@owst

owst commented Nov 3, 2025

Copy link
Copy Markdown

@xtreme-shane-lattanzio is this something you could help get merged and released please?

@sorenstoutner

Copy link
Copy Markdown

Lack of rubyzip 3 support is holding up the Debian rubyzip transition.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1121395

@fabrik42

Copy link
Copy Markdown

Hello there,
I am a happy LicenseFinder user for many years and I am also facing this issue as a blocker.

Since the PR is open for quite a while, is there anything I could do to support moving forward?

@randikabanura

randikabanura commented May 25, 2026

Copy link
Copy Markdown

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1121395

Hi @sorenstoutner, I think Debian support is now achieved, can we move forward with this PR?

@sorenstoutner

Copy link
Copy Markdown

Debian already cherry-picked this patch and used it in their packaging. After this is merged, we can drop our local patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants