Azure: fix subnet reserved ranges#64
Open
zmb3 wants to merge 2 commits into
Open
Conversation
The reserved range is a range of IP addresses, so the output should reserve the first 10 IPs in each subnet, not only the 10th IP.
Author
|
Note: my editor automatically formatted the changed files to match HCL convention of lining up the |
Include PKS subnet as well.
Contributor
|
Looks good to me, will schedule to merge it. |
Contributor
|
Thanks @zmb3 you're the best! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reserved range is a range of IP addresses, so the output should reserve the first 10 IPs in each subnet, not only the 10th IP.
(This is already the case for the AWS and GCP templates in this repo.)
With this change, the output shows: