Merge branch 'master' of https://github.com/pixelgrade/nova-blocks

pixelgrade · Jul 16, 2021 · cc4c6e3 · cc4c6e3
2 parents 4c410c1 + 2719cd8
commit cc4c6e3
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/packages/block-library/src/blocks/hero/frontend.js b/packages/block-library/src/blocks/hero/frontend.js
@@ -5,7 +5,9 @@ import '@novablocks/doppler/frontend';
 	let windowScrollY;
 	let scrollButtonHidden = false;
 
-	const $scrollButton = $( '.novablocks-hero__indicator' );
+	const $scrollButton = $( '.novablocks-hero__indicator' ),
+        $scrollButtonMiddle = $scrollButton.filter( '.novablocks-hero__indicator--middle' ),
+        SCROLL_BUTTON_HIDDEN_CLASS = 'novablocks-hero__indicator--hidden';
 
 	bulletsInit();
 	scrollButtonInit();
@@ -16,9 +18,7 @@ import '@novablocks/doppler/frontend';
 	function updateScroll() {
 		windowScrollY = window.scrollY;
 
-		if ( windowScrollY > 200 ) {
-			hideScrollButton();
-		}
+    hideScrollButton( windowScrollY );
 	}
 
 	function bulletsInit() {
@@ -30,15 +30,14 @@ import '@novablocks/doppler/frontend';
 		}
 	}
 
-	function hideScrollButton() {
-
-		if ( scrollButtonHidden ) {
-			return;
-		}
+	function hideScrollButton( scrollY ) {
 
-		$scrollButton.filter( '.novablocks-hero__indicator--middle' ).addClass( 'novablocks-hero__indicator--hidden' );
-		scrollButtonHidden = true;
+	  const hideScrollButton = scrollY > 200;
 
+	  if ( hideScrollButton !== scrollButtonHidden ) {
+      $scrollButtonMiddle.toggleClass(SCROLL_BUTTON_HIDDEN_CLASS);
+      scrollButtonHidden = hideScrollButton;
+    }
 	}
 
 	function scrollButtonInit() {