Skip to content

fix: Add appropriate hover color to Header's navbar buttons (social icons) #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: Add appropriate hover color to Header's navbar buttons (social icons) #1412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f6794f
rhymes17 commit
rhymes17 Apr 2, 2024
d609c46
youtube button color changed
rhymes17 Apr 2, 2024
f261423
Merge pull request #1 from rhymes17/feat/rhymes17Feat
rhymes17 Apr 2, 2024
1211b46
Add colors to icons on hover
rhymes17 Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions components/Header/Header.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,27 +21,26 @@ import {
AiFillEdit,
} from "react-icons/ai";


const NAV__LINK = [
{
path: "/",
display: "Home",
openInNewPage:false,
openInNewPage: false,
},
{
path: "/#courses",
display: "Courses",
openInNewPage:false,
openInNewPage: false,
},
{
path: "/gears",
display: "My Gears",
openInNewPage:false,
openInNewPage: false,
},
{
path: "https://blog.piyushgarg.dev",
display: "Blogs",
openInNewPage:true,
openInNewPage: true,
},
];

Expand Down Expand Up @@ -113,11 +112,19 @@ const Header = () => {
key={index}
className={`${classes.mobile__menuDiv} cursor-pointer`}
>
<Link aria-label={item.display} href={item.path} target={`${item.openInNewPage?'_blank':'_self'}`}>
<Link
aria-label={item.display}
href={item.path}
target={`${item.openInNewPage ? "_blank" : "_self"}`}
>
<p className={`${classes.mobile__menu}`}>{icons[index]}</p>
</Link>

<Link aria-label={item.display} href={item.path} target={`${item.openInNewPage?'_blank':'_self'}`}>
<Link
aria-label={item.display}
href={item.path}
target={`${item.openInNewPage ? "_blank" : "_self"}`}
>
<span className=" text-[#808dad] hover:text-green-400">
{item.display}
</span>
Expand Down Expand Up @@ -167,7 +174,7 @@ const Header = () => {
target="_blank"
title="Youtube Channel"
id="youtube-channel"
className={`cursor-pointer text-[#ffffff] hover:text-[--site-theme-color] transform ease-in-out hover:-translate-y+1 hover:scale-150`}
className={`cursor-pointer text-[#ffffff] hover:text-red-600 hover:text-[--site-theme-color] transform ease-in-out hover:-translate-y+1 hover:scale-150`}
rel="noreferrer"
>
<RiYoutubeFill />
Expand All @@ -178,7 +185,7 @@ const Header = () => {
target="_blank"
title="Github Account"
id="github-account"
className={`cursor-pointer text-[#ffffff] hover:text-[--site-theme-color] transform ease-in-out hover:-translate-y+1 hover:scale-150`}
className={`cursor-pointer text-[#ffffff] hover:text-black hover:text-[--site-theme-color] transform ease-in-out hover:-translate-y+1 hover:scale-150`}
rel="noreferrer"
>
<RiGithubFill />
Expand All @@ -189,18 +196,18 @@ const Header = () => {
target="_blank"
title="Twitter Account"
id="twitter-account"
className={`cursor-pointer text-[#ffffff] hover:text-[--site-theme-color] transform ease-in-out hover:-translate-y+1 hover:scale-150`}
className={`cursor-pointer text-[#ffffff] hover:text-blue-400 hover:text-[--site-theme-color] transform ease-in-out hover:-translate-y+1 hover:scale-150`}
rel="noreferrer"
>
<NewTwitterLogo/>
<NewTwitterLogo />
</Link>

<Link
href="https://www.linkedin.com/in/piyushgarg195/"
target="_blank"
title="LinkedIn Account"
id="linkedin-account"
className={`cursor-pointer text-[#ffffff] hover:text-[--site-theme-color] transform ease-in-out hover:-translate-y+1 hover:scale-150`}
className={`cursor-pointer hover:text-blue-800 text-[#ffffff] hover:text-[--site-theme-color] transform ease-in-out hover:-translate-y+1 hover:scale-150`}
rel="noreferrer"
>
<RiLinkedinFill />
Expand Down
Loading