pjmedia: Handle zero-port bundle-only offers#5067
Merged
Merged
Conversation
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates PJMEDIA’s SDP negotiation to accept RFC 9143 “bundle-only” offered media sections that use port 0, so they aren’t rejected before codec negotiation when their a=mid is included in the session-level a=group:BUNDLE line.
Changes:
- Added detection of valid
port=0 + a=bundle-only + a=mid in group:BUNDLEoffered media sections. - Updated offer/answer matching to only deactivate zero-port sections when they are not valid bundle-only offers.
- Added a regression test covering the bundle-only zero-port offer case.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pjmedia/src/pjmedia/sdp_neg.c | Adds bundle-only detection and threads it into match_offer() so valid bundle-only port=0 offers aren’t deactivated. |
| pjmedia/src/test/sdp_neg_test.c | Adds a regression test ensuring negotiation succeeds and the bundle-only media section is not answered with port 0. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
sauwming
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes handling of zero-port
a=bundle-onlymedia sections in SDP offers.The issue was found while working on Asterisk issue
asterisk/asterisk#2010, where a WebRTC offer contained multiple media sections in a BUNDLE group.RFC 9143 allows a bundled media section to use port zero when it contains
a=bundle-only. Previously, pjmedia rejected every zero-port media section before codec negotiation.The fix:
a=bundle-only,a=mid,a=group:BUNDLE,Other zero-port media sections keep the existing rejection behavior.
Testing
make pjmedia-test.port=0 + bundle-only + MID in group:BUNDLE.