Skip to content

Commit

Permalink
[CHORE] #87 : pendingResult 로직 삭제
Browse files Browse the repository at this point in the history
  • Loading branch information
jeongjaino committed Jan 11, 2024
1 parent 2aad7c3 commit a4d50f3
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 10 deletions.
1 change: 1 addition & 0 deletions .idea/gradle.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.wap.wapp.core.data.repository.auth

interface SignInRepository {
suspend fun hasPendingResult(): Boolean

suspend fun signIn(email: String): Result<String>
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,5 @@ import javax.inject.Inject
class SignInRepositoryImpl @Inject constructor(
private val signInDataSource: SignInDataSource,
) : SignInRepository {
override suspend fun hasPendingResult(): Boolean = signInDataSource.hasPendingResult()

override suspend fun signIn(email: String): Result<String> = signInDataSource.signIn(email)
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
package com.wap.wapp.core.network.source.auth

interface SignInDataSource {
suspend fun hasPendingResult(): Boolean

suspend fun signIn(email: String): Result<String>
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@ class SignInDataSourceImpl @Inject constructor(
private val firebaseAuth: FirebaseAuth,
@ActivityContext private val context: Context,
) : SignInDataSource {
override suspend fun hasPendingResult(): Boolean {
return firebaseAuth.pendingAuthResult != null
}

override suspend fun signIn(email: String): Result<String> {
return runCatching {
val provider = OAuthProvider.newBuilder("github.com")
Expand Down

0 comments on commit a4d50f3

Please sign in to comment.