pkp/pkp-lib#1550 Controlled vocabulary support #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jyhein
commented
Jan 22, 2025
jyhein
commented
- Use external source to add new keywords etc. using plugins
- Save extra data (identifier, source) with the term to db
jyhein
force-pushed
the
f1550
branch
6 times, most recently
from
a663eaf to
9d70718
Compare
touhidurabir
reviewed
Feb 3, 2025
There was a problem hiding this comment.
@jyhein I added few questions/suggestion, nothing critical . Please take a look when you get time .
Comment on lines
+5
to
+15
| function setSuggestion(value) { | ||
| const {name, label = null, identifier = null, ...extraItems} = value; | ||
| const suggestion = { | ||
| value: value, | ||
| label: label ?? name, | ||
| identifier: identifier, | ||
| ...(extraItems ? {extraItems: extraItems} : {}), | ||
| }; | ||
| return suggestion; | ||
| } | ||
|
|
There was a problem hiding this comment.
Any particular reason we are making this as general method than as the part of component's method ? Also If I understand correctly, this method takes the data coming from plugin and transform it to support the updated schema . If that is the case , perhaps a different name so that it does not confuse the setSuggestions method coming form FieldBaseAutosuggest component ?
There was a problem hiding this comment.
Hmmm...shouldn't this be private? When it is outside export
src/pages/workflow/components/publication/WorkflowPublicationForm.vue
Outdated
Show resolved
Hide resolved
jyhein
force-pushed
the
f1550
branch
2 times, most recently
from
1c1d3e3 to
ed64194
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.