Optimize table section reloads after closing an unsaved modal#853
Open
blesildaramirez wants to merge 14 commits into
Open
Optimize table section reloads after closing an unsaved modal#853blesildaramirez wants to merge 14 commits into
blesildaramirez wants to merge 14 commits into
Conversation
blesildaramirez
force-pushed
the
optimize-table-reloads
branch
3 times, most recently
from
96bc98e to
4297cc7
Compare
jardakotesovec
requested changes
Apr 14, 2026
Contributor
jardakotesovec
left a comment
jardakotesovec
left a comment
There was a problem hiding this comment.
Lets discuss this further on catch up. One of the goals I think was to reload the data before closing the modal, which per my testing is not happening (tried it on the task template manager).
Otherwise conceptually I think its good idea.
| // Auto-track data changes for mutations inside modals | ||
| if ( | ||
| ['POST', 'PUT', 'DELETE'].includes(options.method) && | ||
| modalStore.dialogLevel > 0 |
Contributor
There was a problem hiding this comment.
should be used the modalLevel which is available above?
Might not make difference but dialogLevel was made intentionally to guide dialogs on which levels to show up.
…o onClose functions
…trigger data changed calls
…ing outside modal)
blesildaramirez
force-pushed
the
optimize-table-reloads
branch
from
78e82f8 to
20b9700
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details of the changes:
triggerDataChange(). Passing an empty param to thetriggerDataChange()function will always trigger all the callbacks. Example where we use this is when Uploading Files, where there are multiple ajax legacy modals steps that only pass thedataChangedat the last step. Skipping midway prevents the reload of the files, so we need to always ensure that opening File Uploads always refreshes the list. Adding new Galley also opens the File Uploads in the process, so this one also requires this approach.triggerDataChangeapi and manually refetches some list, so manual checks were added:shouldTriggerDataChange(closeData)triggerDataChange, so all params sent to it will propagate directly totriggerDataChangeapi.