Skip to content

pkp/pkp-lib#12497 Restrict access to edit participant button#868

Merged
Vitaliy-1 merged 1 commit into
pkp:stable-3_5_0from
Vitaliy-1:stable-3_5_0-i12497
Apr 10, 2026
Merged

pkp/pkp-lib#12497 Restrict access to edit participant button#868
Vitaliy-1 merged 1 commit into
pkp:stable-3_5_0from
Vitaliy-1:stable-3_5_0-i12497

Conversation

@Vitaliy-1
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@jardakotesovec jardakotesovec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided one suggestion on organisation if you can try. But its not deal breaker :-).

stageAssignment,
props.submission,
participants
),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall looks great. My only preference would be to have this calculation in getItemActions.

Can you try - I think it should be quite easy change - if you need more data available in the getItemActions. You can add them

		function getItemActions({participant}) {
			return participantManagerConfig.getItemActions({
				submission: props.submission,
				submissionStageId: props.submissionStageId,
				participant,
			});
		}

Reason for it that this place is just for mapping to make the participant shape easier to work with. But the logic what to display is happening in the config functions.

@Vitaliy-1 Vitaliy-1 force-pushed the stable-3_5_0-i12497 branch from 4671049 to 68d486b Compare April 10, 2026 11:41
@Vitaliy-1 Vitaliy-1 merged commit ce77c6b into pkp:stable-3_5_0 Apr 10, 2026
5 checks passed
@Vitaliy-1 Vitaliy-1 deleted the stable-3_5_0-i12497 branch April 10, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants