pkp/pkp-lib#12497 Restrict access to edit participant button#868
Merged
Conversation
1 task
Contributor
jardakotesovec
left a comment
There was a problem hiding this comment.
Provided one suggestion on organisation if you can try. But its not deal breaker :-).
| stageAssignment, | ||
| props.submission, | ||
| participants | ||
| ), |
Contributor
There was a problem hiding this comment.
This overall looks great. My only preference would be to have this calculation in getItemActions.
Can you try - I think it should be quite easy change - if you need more data available in the getItemActions. You can add them
function getItemActions({participant}) {
return participantManagerConfig.getItemActions({
submission: props.submission,
submissionStageId: props.submissionStageId,
participant,
});
}
Reason for it that this place is just for mapping to make the participant shape easier to work with. But the logic what to display is happening in the config functions.
4671049 to
68d486b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.