Code

A Procedural Solution#4

Code

Draft

plainprogrammer wants to merge 22 commits intomainplainprogrammer/GildedRose.rb:mainfrom

Sample-Solution-001plainprogrammer/GildedRose.rb:Sample-Solution-001Copy head branch name to clipboard

Commits

Commits on Oct 20, 2021

• Flatten first conditional block to clarify what item type is in scope.

  plainprogrammer

  committed
  b2422b2

  Copy full SHA for b2422b2

• Replace negative condition with positive condition to reveal what item type we are checking in first conditional.

  plainprogrammer

  committed
  82d71d3

  Copy full SHA for 82d71d3

• Convert second top-level condition to unless for clarity of check.

  plainprogrammer

  committed
  7ec8972

  Copy full SHA for 7ec8972

• Reverse conditional structure to state positive case for backstage pass item type in third conditional block.

  plainprogrammer

  committed
  262663d

  Copy full SHA for 262663d

• Pulled nested conditional to higher level to reduce nesting in third conditional section.

  plainprogrammer

  committed
  3548bed

  Copy full SHA for 3548bed

• Inlined all quality guard clauses to further flatten conditionals.

  plainprogrammer

  committed
  5a4aa41

  Copy full SHA for 5a4aa41

• Extract decrement quality method to reduce duplication.

  plainprogrammer

  committed
  5fc9d48

  Copy full SHA for 5fc9d48

• Extract increment quality method to reduce duplication.

  plainprogrammer

  committed
  27f9b34

  Copy full SHA for 27f9b34

• Changed first conditional section to a case statement to clarify item type behavior.

  plainprogrammer

  committed
  b4076af

  Copy full SHA for b4076af

• Introduce ability to adjust quality increment via argument.

  plainprogrammer

  committed
  b0e6242

  Copy full SHA for b0e6242

• Use ability to specify quality increment amount to clarify how backstage passes behave.

  plainprogrammer

  committed
  f98b49c

  Copy full SHA for f98b49c

• Flatten nested conditional in third conditional section to clarify item type behavior.

  plainprogrammer

  committed
  93f2801

  Copy full SHA for 93f2801

• Change third conditional section to use case to clarify item type behavior.

  plainprogrammer

  committed
  c7e74a2

  Copy full SHA for c7e74a2

• Extracted conditional for expiration detection into method to clarify intent.

  plainprogrammer

  committed
  8ff3fb5

  Copy full SHA for 8ff3fb5

• Consolidate all item behaviors into singular case statement within update quality method.

  plainprogrammer

  committed
  a27f6d8

  Copy full SHA for a27f6d8

• Extract item type behaviors into discreet update methods.

  plainprogrammer

  committed
  d88e08d

  Copy full SHA for d88e08d

• Reordered methods to clarify their relationship to each other.

  plainprogrammer

  committed
  ca13f0b

  Copy full SHA for ca13f0b

• Changed expiration behavior for updating backstage pass for increased clarity.

  plainprogrammer

  committed
  5386e02

  Copy full SHA for 5386e02

• Rearranged code for updating aged brie to adjust sell in before adjusting quality.

  plainprogrammer

  committed
  e2ea8b4

  Copy full SHA for e2ea8b4

• Rearranged code for updating backstage passes to adjust sell in before adjusting quality.

  plainprogrammer

  committed
  ce0c8f4

  Copy full SHA for ce0c8f4

• Rearranged code for updating normal items to adjust sell in before adjusting quality.

  plainprogrammer

  committed
  c95a9aa

  Copy full SHA for c95a9aa

• Add support for the Conjured Mana Cake item.

  plainprogrammer

  committed
  58de357

  Copy full SHA for 58de357