Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tljh_extra_hub_pip_packages hook match pyproject.toml #88

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

TimoRoth
Copy link
Contributor

I was wondering why even a new install ends up with a really old version of this.
That hook is probably why.

@trungleduc
Copy link
Collaborator

Hi, thank you for your contribution. Do the tests pass locally for you?

@TimoRoth
Copy link
Contributor Author

So far I didn't run them, since the change seemed somewhat trivial.
I have manually updated dockerspawner on our hub env though and there are no obvious issues so far.

@TimoRoth
Copy link
Contributor Author

The test failure looks genuine. But it's not a change in the docker python modules, but a change by the docker engine itself.
Compare https://docs.docker.com/reference/api/engine/version/v1.26/#tag/Image/operation/ImageInspect with https://docs.docker.com/reference/api/engine/version/v1.47/#tag/Image/operation/ImageInspect
The ContainerConfig item was renamed to just Config it seems.

@TimoRoth
Copy link
Contributor Author

Turns out the code itself already deals with this change: https://github.com/plasmabio/tljh-repo2docker/blob/master/tljh_repo2docker/__init__.py#L137
It's just the tests that don't.

Docker Engine API renamed ContainerConfig to Config in v1.45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants