[WordPress] review Anouck #3891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Platform.sh environment has successfully deployed. 🚀 See the site: |
Merged
There was a problem hiding this comment.
@AnouckColson This is great, only a few comments on my end. Otherwise I think it's good to go and #3866 can be closed in favor of this one.
chadwcarlson
approved these changes
Mar 28, 2024
AnouckColson
added a commit
that referenced
this pull request
Apr 3, 2024
* Bump versions for GA docs. * Update trial buttons + CTA banners. (#3840) * Remove 64 character Let's Encrypt limitation (#3876) * Revert "Revert instance mounts and temporary alias doc" (#3868) * Document billing (#3812) * Document billing * Add info on calculations * Review explanations on estimates * Small fixes * Other small fixes * Fix copy paste * Apply suggestions from review * Add screenshots * Update formula * Document configurable build resources (#3782) * Document build resources * Add note * Add notes * Apply feedback from review --------- Co-authored-by: chadcarlson <[email protected]> * Update secondary vendor site name (#3841) * Rename secondary vendor site to upsun. * Not found error + timeout. * Update scope. * again. * Update regions.md (#3892) * allow checks & environments for PRs against ga-staging * Add framework section landing page.' (#3894) * Update GS link + wrongly inherited content. (#3897) * [WordPress] review Anouck (#3891) * init commit * adds additional files section * adds locations and mounts sections * corrects issue with the header information formatting * final change sections, adds documentation, community content, blogs sections * spelling, grammatical updates/corrections * Review * Fix description and snippets * Update table and apply suggestions. --------- Co-authored-by: Paul Gilzow <[email protected]> Co-authored-by: chadcarlson <[email protected]> * Add PHP and Python continuous profiling documentation (#3895) * Add PHP and Python continuous profiling documentation * Add CPU support for the node.js cont profiler * Doc review --------- Co-authored-by: Anouck Colson <[email protected]> Co-authored-by: chadcarlson <[email protected]> * [Upsun] Custom backup schedules (#3890) * Draft for the self-service automated-backup configuration * Doc review * Multi-line PATCH calls. --------- Co-authored-by: remi <[email protected]> Co-authored-by: Anouck Colson <[email protected]> Co-authored-by: chadcarlson <[email protected]> * Update teams feature availability for GA/self-service. (#3908) * [Laravel] Resubmit: Adding the "Getting started" guide for Laravel (#3899) * Clone the Symfony Getting Started. The page is done. * Correct typo on get-started * WIP: First version of the laravel getting started guide * First version of the Laravel Get Started Guide * Update sites/friday/src/get-started/stacks/laravel/_index.md Co-authored-by: Thomas di Luccio <[email protected]> * Update sites/friday/src/get-started/stacks/laravel/blackfire.md Co-authored-by: Thomas di Luccio <[email protected]> * Update sites/friday/src/get-started/stacks/laravel/crons.md Co-authored-by: Thomas di Luccio <[email protected]> * Update sites/friday/src/get-started/stacks/laravel/environment-variables.md Co-authored-by: Thomas di Luccio <[email protected]> * Update sites/friday/src/get-started/stacks/laravel/faq.md Co-authored-by: Thomas di Luccio <[email protected]> * Update sites/friday/src/get-started/stacks/laravel/faq.md Co-authored-by: Thomas di Luccio <[email protected]> * Update sites/friday/src/get-started/stacks/laravel/faq.md Co-authored-by: Thomas di Luccio <[email protected]> * Update sites/friday/src/get-started/stacks/laravel/faq.md Co-authored-by: Thomas di Luccio <[email protected]> * Doc review --------- Co-authored-by: Guillaume Moigneu <[email protected]> Co-authored-by: Guillaume Moigneu <[email protected]> Co-authored-by: Thomas di Luccio <[email protected]> Co-authored-by: Anouck Colson <[email protected]> * [Express] Getting started guide (#3904) * Reinstate Express GS guide. * Fix express links. add add-database page. * Doc review --------- Co-authored-by: Anouck Colson <[email protected]> * Restore simplified relationships (updated) (#3881) * Update registry to use service names for relationship names. * add-services/_index.md * add-services/headless-chrome.md * themes/../partials/examples/relationships.html * themes/../partials/examples/servicedefn.html * themes/../shortcodes/endpoint-description.md * themes/../shortcodes/v2connect2app.md * add-services/influxdb.md * Fix usage example indents and comment spacing. * add-services/kafka * add-services/memcached. * Fix double = typo. * add-services/mongodb.md * endpoint-description > oracle-mysql fix * add-services/mysql/_index.md * add-services/mysql/mysql-replication. * add-services/network-storage * add-services/opensearch.md * add-services/postgresql * add-services/rabbitmq.md * add-services/redis * add-services/solr.md * add-services/varnish * Fix random character mistake. * create-apps/_index.md * create-apps/app-reference * guides/drupal/redis. * languages/elixir. * languages/java/migration * languages/lisp. * languages/ruby. * learn/tutorials/restrict-service-access * create-apps/workers. * [guides|get-started/stacks]/symfony/environment-variables * [Next.js] Getting started guide (#3903) * Reinstate Next.js GS guide. * Doc review --------- Co-authored-by: Anouck Colson <[email protected]> * Composable image (#3879) * first draft for composable image on Upsun side (only for now) * report changes to platform folder * some improvement on Upsun composable image * adding multiple runtimes note + NixOs presentation draft * adding note at the beginning of PHP doc page (draft) * adding disclaimer on languages and align P.sh with Upsun composable * removing top level key from Upsun + reformat code + adding TODO block in the HTML * Apply doc review and suggestions from Jerome * missing replacement of built-in image * split codetab for PHP ext and Python to separate section * remaining built-in image * remaining built-in image * Move PHP-specific content and redorder side nav * Remove extra space * PHP extensions update * Update PSH composable image page * Update PSH section index page * Reorder side nav for PSH * Fix numbering * Further review suggestions applied * Fix links. Remove duplicated file on conflict resolution. * Add redirect notes where relevant (for type and extensions). * Add the sticky note option, even though its not yet enabled. * Fix failing 'Check internal links' for platform docs. * Match fixed links on upsun docs. * Fix note. * Fix platform config from using upsun config. * Fix platform file name. * socket_family/protocol for primary runtimes * Update example configuration for PHP runtime config. * Fix links post-merge. * Link checks on builds. * Fix side nav --------- Co-authored-by: Anouck Colson <[email protected]> Co-authored-by: chadcarlson <[email protected]> * [Strapi] Getting started guide (#3905) * Reinstate Strapi GS guide. * Add an add-database page to Strapi section. * Doc review --------- Co-authored-by: Anouck Colson <[email protected]> * [Django + Flask] Getting Started Frameworks section for Upsun (#3816) * WIP: initial changes to the Django stacks page * finishes out the remaining steps, small configuration change * adds flask instructions * corrects indentation between from and to for deploy hook examples * Update sites/friday/src/get-started/stacks/django.md Co-authored-by: Chad Carlson <[email protected]> * Update sites/friday/src/get-started/stacks/django.md Co-authored-by: Chad Carlson <[email protected]> * Update sites/friday/src/get-started/stacks/flask.md Co-authored-by: Chad Carlson <[email protected]> * adds the remaining bits to the flask doc * adds section on alternative web servers and db migrate * removes naming a specific number of remaining steps * Match Django guide with the WordPress guide. * Match Flask guide with the WordPress format. * Doc review --------- Co-authored-by: Chad Carlson <[email protected]> Co-authored-by: chadcarlson <[email protected]> Co-authored-by: Anouck Colson <[email protected]> * Fix composable image xdebug configuration. (#3915) * Pre-GA fixes (#3917) * fix vale errors . * Fix bad merges. * Remove hardcoded company names. --------- Co-authored-by: AnouckColson <[email protected]> Co-authored-by: Paul Gilzow <[email protected]> Co-authored-by: Thomas di Luccio <[email protected]> Co-authored-by: Anouck Colson <[email protected]> Co-authored-by: remilejeune2 <[email protected]> Co-authored-by: remi <[email protected]> Co-authored-by: Guillaume Moigneu <[email protected]> Co-authored-by: Guillaume Moigneu <[email protected]> Co-authored-by: Thomas di Luccio <[email protected]> Co-authored-by: flovntp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes #{ISSUE_NUMBER}
What's changed