Remove Mint timeout #241
Merged
Remove Mint timeout #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslandoga
force-pushed
the
remove-mint-timeout
branch
3 times, most recently
from
514fac8 to
7322545
Compare
ruslandoga
force-pushed
the
remove-mint-timeout
branch
from
7322545 to
3da4ee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #216
Right now there are two timeout mechanisms, DBConnection's ownership timeout, and Mint's TCP recv timeout. It's complicated and sometimes results in a race condition where the same underlying issue is represented by two different exceptions
%Mint.TransportError{reason: :timeout}andDBConnection.ConnectionError. After this PR only DBConnection would be responsible for timeouts.