-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scalafmt-core to 3.5.3 #458
Update scalafmt-core to 3.5.3 #458
Conversation
build.sbt
Outdated
@@ -4,6 +4,43 @@ import Common._ | |||
import com.typesafe.tools.mima.core._ | |||
import com.typesafe.tools.mima.plugin.MimaKeys.{ mimaBinaryIssueFilters, mimaPreviousArtifacts } | |||
|
|||
// Customise sbt-dynver's behaviour to make it work with tags which aren't v-prefixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would rather keep it in version.sbt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you insist, ok, we can keep it there. (In all the other Play repos we removed version.sbt
to make clear we now use sbt-dynver, and also keep the dynver configs in build.sbt
)
Long term solution however IMHO is that we add a config to sbt-dynver to achieve what you did here: sbt/sbt-dynver#227 (if you want you can provide a PR to sbt-dynver 😉 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why having everything in build.sbt
rather than modular files would make it clear?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superseded by #470. |
Updates org.scalameta:scalafmt-core from 3.5.2 to 3.5.3.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency:
labels: library-update, early-semver-patch, semver-spec-patch, commit-count:n:2