Add thousandsStay setting. #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set default prefix to "US$ " and default affixStay to "false". Added thousandsStay setting with default value of "false".
Changed prefix, affixesStay, and thousandsStay default values from personalized to more general purpose settings.
|
Hmmm there seems to be a difference between the whitespace display on GitHub for Windows and editing the code from a browser. Sorry, was trying to figure it out. |
|
I had updated my solution to match yours, in order to keep in sync prior to merge, but discovered we both had it wrong. It needs a regExp to get multiple separators, so I've updated to use that, which seems to work and is passing CI. |
Replaced ALL occurrences of the thousands symbol using a global regexp.
|
Yes, thank you. I've updated my branches with this fix. |
|
Closing this pull request to consolidate work to #144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my take on adding a thousandsStay setting, which is working for my purposes.