Skip to content

Commit

Permalink
Accept 1 and y as true values for use_prerelease_versions (#61)
Browse files Browse the repository at this point in the history
  • Loading branch information
davisagli authored Feb 4, 2025
1 parent 9c27a38 commit f57ccd9
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
4 changes: 4 additions & 0 deletions cookieplone/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ def parse_extra_content(value: list[str]) -> dict:
return dict([s.split("=") for s in value])


def parse_boolean(value: str) -> bool:
return value.lower() in ("1", "yes", "y")


def prompt_for_template(base_path: Path) -> str:
"""Parse cookiecutter.json in base_path and prompt user to choose."""
templates = get_template_options(base_path)
Expand Down
5 changes: 3 additions & 2 deletions cookieplone/filters/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

from cookiecutter.utils import simple_filter

from cookieplone.cli import parse_boolean
from cookieplone.utils import containers, versions


Expand Down Expand Up @@ -64,14 +65,14 @@ def use_prerelease_versions(_: str) -> str:
@simple_filter
def latest_volto(use_prerelease_versions: str) -> str:
"""Return the latest released version of Volto."""
allow_prerelease = use_prerelease_versions == "Yes"
allow_prerelease = parse_boolean(use_prerelease_versions)
return versions.latest_volto(allow_prerelease=allow_prerelease)


@simple_filter
def latest_plone(use_prerelease_versions: str) -> str:
"""Return the latest released version of Plone."""
allow_prerelease = use_prerelease_versions == "Yes"
allow_prerelease = parse_boolean(use_prerelease_versions)
return versions.latest_plone(allow_prerelease=allow_prerelease)


Expand Down
1 change: 1 addition & 0 deletions news/47.bugfix
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix parsing of boolean values for use_prerelease_versions. @davisagli

0 comments on commit f57ccd9

Please sign in to comment.