Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mockup landing page to docs #1626

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Add Mockup landing page to docs #1626

merged 5 commits into from
Feb 15, 2024

Conversation

stevepiercy
Copy link
Contributor

Supersedes and closes #1548.

This is the first version of the Mockup landing page. Once @fredvd has completed GitHub workflow work to synch the mockup demo to https://6.docs.plone.org/mockup, then I will update links accordingly.

Copy link

netlify bot commented Feb 15, 2024

Deploy Preview for 6-docs-plone-org ready!

Name Link
🔨 Latest commit 9002a23
🔍 Latest deploy log https://app.netlify.com/sites/6-docs-plone-org/deploys/65ce1d83cf7e5c0008ceedc7
😎 Deploy Preview https://deploy-preview-1626--6-docs-plone-org.netlify.app/glossary.html
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stevepiercy stevepiercy self-assigned this Feb 15, 2024
@stevepiercy
Copy link
Contributor Author

MrTango
MrTango previously approved these changes Feb 15, 2024
Copy link
Contributor

@MrTango MrTango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed a bit the description what Mockup is.
Please check, other than that, good to go.

petschki
petschki previously approved these changes Feb 15, 2024
Copy link
Member

@petschki petschki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevepiercy stevepiercy dismissed stale reviews from petschki and MrTango via c9e3a00 February 15, 2024 14:12
@stevepiercy
Copy link
Contributor Author

Thank you @petschki @MrTango for feedback.

This is just the beginning for us server-side template recidivists.

The failing test is a GitHub bug with rendering README.rst. Merging.

@stevepiercy stevepiercy merged commit 0384fa6 into 6.0 Feb 15, 2024
5 of 6 checks passed
@stevepiercy stevepiercy deleted the mockup-page branch February 15, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants