Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run plone minor fixes #1872

Merged
merged 7 commits into from
Feb 24, 2025
Merged

Run plone minor fixes #1872

merged 7 commits into from
Feb 24, 2025

Conversation

gamboz
Copy link
Contributor

@gamboz gamboz commented Feb 21, 2025

Issue number

  • Untracked

Description

I think that the instructions about how to run a debug console with pip might be wrong. When using zconsole one probably need zope.conf, not zope.ini.

I'm also adding a note about setRequest() copied from https://community.plone.org/t/interactive-shell-for-debugging-with-plone-6-docker-compose-the-wsgi-equivalent-of-bin-instance-debug/16370/9?u=gamboz


📚 Documentation preview 📚: https://plone6--1872.org.readthedocs.build/

Copy link

boring-cyborg bot commented Feb 21, 2025

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, read Plone's Code of Conduct and Contribute to documentation, as this will greatly help the review process.

Welcome to the Plone community! 🎉

@stevepiercy
Copy link
Contributor

Thank you for your contribution! I requested a review from the three people who commented on the forum, as I have no clue whether this is technically correct or not. We need a content expert to review its accuracy. I merely provided a MyST syntax review.

@gamboz
Copy link
Contributor Author

gamboz commented Feb 21, 2025

@stevepiercy thanks for the corrections. They should have been done.

@gamboz gamboz marked this pull request as ready for review February 21, 2025 14:03
@gamboz gamboz requested a review from stevepiercy February 21, 2025 14:15
stevepiercy
stevepiercy previously approved these changes Feb 22, 2025
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gamboz. MyST syntax looks good. Let's wait for a technical review from one of the three people I requested. This should be quick one.

@davisagli davisagli merged commit 42e6720 into plone:6.0 Feb 24, 2025
2 checks passed
Copy link

boring-cyborg bot commented Feb 24, 2025

Congratulations on your first merged pull request in this project! 🎉
Congratulations

Thank you for contributing, we are very proud of you! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants