Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port robot tests #673

Closed
wants to merge 55 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
8fda824
feat(robot): port tests to playwright
gforcada Oct 8, 2023
ec17b68
Add news entry
gforcada Oct 8, 2023
3cbf488
Preparing release 3.0.3
mauritsvanrees Oct 6, 2023
7ddcef9
Back to development: 3.0.4
mauritsvanrees Oct 6, 2023
c92e75f
Revert "Preparing release 3.0.3"
mauritsvanrees Oct 6, 2023
91b85ae
Preparing release 3.0.4
mauritsvanrees Oct 6, 2023
4dda6f5
Back to development: 3.0.5
mauritsvanrees Oct 6, 2023
a17f77c
Fix link_redirect_view
1letter Oct 19, 2023
66e8e41
Add News
1letter Oct 19, 2023
827b70a
Fix Test
1letter Oct 19, 2023
d3b2a0f
Fix path construction
1letter Oct 19, 2023
063fbe0
Simplify url constrction in link_redirect_view
1letter Oct 19, 2023
d69be29
remove unused imports
1letter Oct 19, 2023
fac8742
Make resolution of uid more robust
1letter Oct 20, 2023
dbce8aa
Update Tests
1letter Oct 20, 2023
1a31e89
Calculate a fragment of path
1letter Oct 20, 2023
b1fc119
Update tests
1letter Oct 20, 2023
9a14cbb
Update 671.bugfix
1letter Oct 20, 2023
bafeced
Preparing release 3.0.5
mauritsvanrees Oct 25, 2023
c778894
Back to development: 3.0.6
mauritsvanrees Oct 25, 2023
3480124
pre commit autoupdate
mauritsvanrees Nov 6, 2023
3134036
Fixed spelling errors.
mauritsvanrees Nov 6, 2023
9d29cd4
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Dec 4, 2023
9d1b689
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Jan 1, 2024
5e0d48b
Configuring with plone/meta
gforcada Jan 20, 2024
0e51aa5
chore: adjust dependencies
gforcada Jan 20, 2024
5bea2c7
chore: typo
gforcada Jan 21, 2024
146ee89
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Feb 5, 2024
366fdfd
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 5, 2024
23aa11b
Fix folder listing template when `plone.eventlocation` behavior is di…
petschki Nov 15, 2023
0e5dbea
Update plone/app/contenttypes/browser/templates/listing.pt
jensens Feb 19, 2024
0303e5e
Preparing release 3.0.6
mauritsvanrees Mar 15, 2024
6dfa09a
Back to development: 3.0.7
mauritsvanrees Mar 15, 2024
59a351d
Fix ILeadImageBehavior and IRichTextBehavior interfaces were the name…
thet Nov 24, 2023
a92a8e5
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Apr 1, 2024
4257395
Preparing release 3.0.7
mauritsvanrees Apr 25, 2024
7bb6070
Back to development: 3.0.8
mauritsvanrees Apr 25, 2024
1e56016
Removed p.a.widgets moved DeprecationWarning
jensens May 2, 2024
c00ff3d
Support using the file template on objects that have no file attributes.
ale-rt Apr 30, 2024
f9808b8
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] May 6, 2024
d3652c8
Preparing release 3.0.8
mauritsvanrees May 30, 2024
d0b6872
Back to development: 3.0.9
mauritsvanrees May 30, 2024
1838f1c
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Jun 3, 2024
152dd17
Configuring with plone/meta
mauritsvanrees Jun 6, 2024
d820fdc
No longer set portal_properties.site_properties.visible_ids on site c…
mauritsvanrees Jun 6, 2024
f66191d
Preparing release 3.0.9
mauritsvanrees Jun 7, 2024
396a935
Back to development: 3.0.10
mauritsvanrees Jun 7, 2024
8f490ad
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Jul 2, 2024
5d95525
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Aug 5, 2024
136d486
do not enable plone.allowdiscussion by default
jensens May 19, 2023
346c64e
tox: use 6.1 constraints.
mauritsvanrees Jun 13, 2024
3143cb6
Bumped version for breaking release.
mauritsvanrees Aug 13, 2024
224ec3c
Preparing release 4.0.0
mauritsvanrees Sep 3, 2024
169ef1c
Back to development: 4.0.1
mauritsvanrees Sep 3, 2024
b92d781
fix merge conflict
1letter Sep 15, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Generated from:
# https://github.com/plone/meta/tree/master/config/default
# https://github.com/plone/meta/tree/main/config/default
# See the inline comments on how to expand/tweak this configuration file
#
# EditorConfig Configuration file, for more details see:
Expand All @@ -13,7 +13,8 @@
root = true


[*] # For All Files
[*]
# Default settings for all files.
# Unix-style newlines with a newline ending every file
end_of_line = lf
insert_final_newline = true
Expand All @@ -29,13 +30,15 @@ max_line_length = off
# 4 space indentation
indent_size = 4

[*.{yml,zpt,pt,dtml,zcml}]
[*.{yml,zpt,pt,dtml,zcml,html,xml}]
# 2 space indentation
indent_size = 2

[*.{json,jsonl,js,jsx,ts,tsx,css,less,scss,html}] # Frontend development
[*.{json,jsonl,js,jsx,ts,tsx,css,less,scss}]
# Frontend development
# 2 space indentation
indent_size = 2
max_line_length = 80

[{Makefile,.gitmodules}]
# Tab indentation (no size specified, but view as 4 spaces)
Expand Down
2 changes: 1 addition & 1 deletion .flake8
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Generated from:
# https://github.com/plone/meta/tree/master/config/default
# https://github.com/plone/meta/tree/main/config/default
# See the inline comments on how to expand/tweak this configuration file
[flake8]
doctests = 1
Expand Down
63 changes: 55 additions & 8 deletions .github/workflows/meta.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Generated from:
# https://github.com/plone/meta/tree/master/config/default
# https://github.com/plone/meta/tree/main/config/default
# See the inline comments on how to expand/tweak this configuration file
name: Meta
on:
Expand All @@ -13,16 +13,63 @@ on:
- main
workflow_dispatch:

##
# To set environment variables for all jobs, add in .meta.toml:
# [github]
# env = """
# debug: 1
# image-name: 'org/image'
# image-tag: 'latest'
# """
##

jobs:
qa:
uses: plone/meta/.github/workflows/qa.yml@master
uses: plone/meta/.github/workflows/qa.yml@main
test:
uses: plone/meta/.github/workflows/test.yml@master
uses: plone/meta/.github/workflows/test.yml@main
coverage:
uses: plone/meta/.github/workflows/coverage.yml@master
uses: plone/meta/.github/workflows/coverage.yml@main
dependencies:
uses: plone/meta/.github/workflows/dependencies.yml@master
release-ready:
uses: plone/meta/.github/workflows/release_ready.yml@master
uses: plone/meta/.github/workflows/dependencies.yml@main
release_ready:
uses: plone/meta/.github/workflows/release_ready.yml@main
circular:
uses: plone/meta/.github/workflows/circular.yml@master
uses: plone/meta/.github/workflows/circular.yml@main

##
# To modify the list of default jobs being created add in .meta.toml:
# [github]
# jobs = [
# "qa",
# "test",
# "coverage",
# "dependencies",
# "release_ready",
# "circular",
# ]
##

##
# To request that some OS level dependencies get installed
# when running tests/coverage jobs, add in .meta.toml:
# [github]
# os_dependencies = "git libxml2 libxslt"
##

##
# To test against a specific matrix of python versions
# when running tests jobs, add in .meta.toml:
# [github]
# py_versions = "['3.12', '3.11']"
##


##
# Specify additional jobs in .meta.toml:
# [github]
# extra_lines = """
# another:
# uses: org/repo/.github/workflows/file.yml@main
# """
##
7 changes: 6 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
# Generated from:
# https://github.com/plone/meta/tree/master/config/default
# https://github.com/plone/meta/tree/main/config/default
# See the inline comments on how to expand/tweak this configuration file
# python related
*.egg-info
*.pyc
*.pyo

# translation related
*.mo

# tools related
build/
.coverage
.*project
coverage.xml
dist/
docs/_build
Expand All @@ -31,6 +35,7 @@ lib64
parts/
pyvenv.cfg
var/
local.cfg

# mxdev
/instance/
Expand Down
9 changes: 6 additions & 3 deletions .meta.toml
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
# Generated from:
# https://github.com/plone/meta/tree/master/config/default
# https://github.com/plone/meta/tree/main/config/default
# See the inline comments on how to expand/tweak this configuration file
[meta]
template = "default"
commit-id = "7723aeaf"
commit-id = "a89af8f2"

[pyproject]
codespell_ignores = "oder,ist,crate"
dependencies_ignores = "['ZServer', 'plone.app.event', 'Products.CFMPlone',]"
dependencies_ignores = "['ZServer', 'plone.app.event', 'Products.CMFPlone',]"

[tox]
constraints_file = "https://dist.plone.org/release/6.1-dev/constraints.txt"
36 changes: 27 additions & 9 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
# Generated from:
# https://github.com/plone/meta/tree/master/config/default
# https://github.com/plone/meta/tree/main/config/default
# See the inline comments on how to expand/tweak this configuration file
ci:
autofix_prs: false
autoupdate_schedule: monthly

repos:
- repo: https://github.com/asottile/pyupgrade
rev: v3.4.0
rev: v3.17.0
hooks:
- id: pyupgrade
args: [--py38-plus]
- repo: https://github.com/pycqa/isort
rev: 5.12.0
rev: 5.13.2
hooks:
- id: isort
- repo: https://github.com/psf/black
rev: 23.3.0
rev: 24.8.0
hooks:
- id: black
- repo: https://github.com/collective/zpretty
rev: 3.1.0a2
rev: 3.1.0
hooks:
- id: zpretty

Expand All @@ -32,11 +32,19 @@ repos:
# """
##
- repo: https://github.com/PyCQA/flake8
rev: 6.0.0
rev: 7.1.1
hooks:
- id: flake8

##
# Add extra configuration options in .meta.toml:
# [pre_commit]
# flake8_extra_lines = """
# _your own configuration lines_
# """
##
- repo: https://github.com/codespell-project/codespell
rev: v2.2.4
rev: v2.3.0
hooks:
- id: codespell
additional_dependencies:
Expand All @@ -58,15 +66,25 @@ repos:
hooks:
- id: pyroma
- repo: https://github.com/mgedmin/check-python-versions
rev: "0.21.2"
rev: "0.22.0"
hooks:
- id: check-python-versions
args: ['--only', 'setup.py,pyproject.toml']
- repo: https://github.com/collective/i18ndude
rev: "6.0.0"
rev: "6.2.1"
hooks:
- id: i18ndude


##
# Add extra configuration options in .meta.toml:
# [pre_commit]
# i18ndude_extra_lines = """
# _your own configuration lines_
# """
##


##
# Add extra configuration options in .meta.toml:
# [pre_commit]
Expand Down
86 changes: 83 additions & 3 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,86 @@ Changelog

.. towncrier release notes start

4.0.0 (2024-09-03)
------------------

Breaking changes:


- Do not enable plone.allowdiscussion by default, it is a core add-on now.
This is for Plone 6.1, so is a breaking change.
[@jensens] (#665)


3.0.9 (2024-06-07)
------------------

Bug fixes:


- No longer set ``portal_properties.site_properties.visible_ids`` on site creation.
The ``portal_properties`` tools is deprecated, ``visible_ids`` was not set as real property, and usage of ``visible_ids`` was largely removed in Plone 5.0 already.
You already can no longer set ``visible ids`` in the Editing control panel, nor in the member preferences.
The only remaining use for ``visible_ids``, if set to true, was to show the page ids on the 'select default page' form.
[maurits] (#125)


3.0.8 (2024-05-30)
------------------

Bug fixes:


- Support using the file template on objects that have no file attributes. [ale-rt] (#688)
- Fixed p.a.widgets `moved` DeprecationWarning [jensens] (#690)


3.0.7 (2024-04-25)
------------------

Bug fixes:


- Fix ILeadImageBehavior and IRichTextBehavior interfaces were the name change was forgotten.
[thet] (#681)


3.0.6 (2024-03-15)
------------------

Bug fixes:


- Fix folder listing template when `plone.eventlocation` behavior is disabled for Events.
[petschki] (#679)


Internal:


- Update configuration files.
[plone devs] (6e36bcc4)


3.0.5 (2023-10-25)
------------------

Bug fixes:


- Fix link_redirect_view, respect vhm vs none-vhm url schemes @1letter (#671)


3.0.4 (2023-10-07)
------------------

Internal:


- Update configuration files.
[plone devs] (7723aeaf)


3.0.3 (2023-05-22)
------------------

Expand Down Expand Up @@ -437,7 +517,7 @@ Bug fixes:
New features:


- Support ILeadImage behavior when display collection album view.
- Support ILeadImageBehavior when display collection album view.
[rodfersou] (#524)
- Add more log-messages during migration from AT to DX.
[pbauer] (#526)
Expand Down Expand Up @@ -516,7 +596,7 @@ Bug fixes:

Breaking changes:

- ILeadImage and IRichText behaviors now have proper "Marker"-Interfaces.
- ILeadImageBehavior and IRichTextBehavior behaviors now have proper "Marker"-Interfaces.
As this was only possible by renaming the schema adapter to *Behavior* to
not break with implementations inside the collective, the FTI-behavior-definition
has changed:
Expand Down Expand Up @@ -770,7 +850,7 @@ New features:

Bug fixes:

- Add translation namesspace and i18n:translate to the dexterity schema
- Add translation namespace and i18n:translate to the dexterity schema
definitions for the content types that have extra field defined on top of the
behavior composition. Otherwise no translations can be picked up.
[fredvd]
Expand Down
11 changes: 11 additions & 0 deletions dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Generated from:
# https://github.com/plone/meta/tree/main/config/default
# See the inline comments on how to expand/tweak this configuration file
version: 2
updates:

- package-ecosystem: "github-actions"
directory: "/"
schedule:
# Check for updates to GitHub Actions every week
interval: "weekly"
6 changes: 3 additions & 3 deletions docs/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ You have several options:
<?xml version="1.0"?>
<object name="Folder" meta_type="Dexterity FTI">
<property name="behaviors" purge="False">
<element value="plone.app.contenttypes.behaviors.leadimage.ILeadImage"/>
<element value="plone.leadimage"/>
</property>
</object>

Expand All @@ -91,7 +91,7 @@ You have several options:
<object name="Folder" meta_type="Dexterity FTI">
<property name="model_file">your.package.content:folder.xml</property>
<property name="behaviors" purge="False">
<element value="plone.app.contenttypes.behaviors.leadimage.ILeadImage"/>
<element value="plone.leadimage"/>
</property>
</object>

Expand Down Expand Up @@ -122,7 +122,7 @@ You have several options:
</schema>
</model>

You could alternatively override the peroperty ``model_file`` of the type-definition with a empty string and use the property ``schema`` to provide your custom python-schema.
You could alternatively override the property ``model_file`` of the type-definition with a empty string and use the property ``schema`` to provide your custom python-schema.

For more complex features you should always consider create custom behaviors and/or write your own content-types since that will most likely give you more flexibility and less problem when you want to upgrade to a newer version in the future.

Expand Down
Loading