Skip to content

Disable the use of the ajax main template for manage portlet views due to some special response parsing. - #203

Merged
thet merged 1 commit into
masterfrom
no_ajax_load
Jun 17, 2025
Merged

Disable the use of the ajax main template for manage portlet views due to some special response parsing.#203
thet merged 1 commit into
masterfrom
no_ajax_load

Conversation

@thet

@thet thet commented Jun 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@mister-roboto

mister-roboto commented Jun 10, 2025

Copy link
Copy Markdown

@thet thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

This was referenced Jun 10, 2025
Merged
Merged
Merged
Closed
@thet

thet commented Jun 11, 2025

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

mauritsvanrees
mauritsvanrees approved these changes Jun 12, 2025
View reviewed changes

@mauritsvanrees mauritsvanrees left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and probably does not hurt even if the related CMFPlone PR would not get merged.

But out of curiosity: what would go wrong without this fix? What is this "special response parsing"? I don't notice anything wrong when I try the combination of PR branches but exclude this one.

Comment thread plone/app/portlets/browser/manage.py Outdated
@thet
thet merged commit 5642baf into master Jun 17, 2025
@thet
thet deleted the no_ajax_load branch June 17, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mauritsvanrees mauritsvanrees mauritsvanrees approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thet @mister-roboto @mauritsvanrees