Next-generation gen_resources
#212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as the recent versions of dash (> 1.21.0) have the `dash_renderer` merged within the dash repo. Namely, we need - grab the `dash_renderer` module from the main `dash` module - to override the `namespace` value with `"dash_renderer" to fetch from the correct URL, we do something similar for the renderer deps just above.
bump the version to use in `Sources.toml` then commmit the updated `Artifacts.toml` after `generate.jl --deploy` pointing to https://github.com/plotly/DashCoreResources/releases/tag/v2.10.2%2B0
clientside callbacks with Promises are now supported by dash since v2.4.0
`invalid-nested-prop` became `allow-nested-prop` in dash 2.1.0 moreover, use same css query as in the python version of the `test_props_check.py` suite
github-actions
bot
added
documentation
etpinard
added
the
priority
|
I've been personally using the updated So, I'll merge this branch into I'm planning on releasing the new artifacts as part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly cherry-picking from #208, this PR updates the 18+ months old artifacts with resources from dash v2.10.2.
The updated tarball is hosted on: https://github.com/plotly/DashCoreResources/releases/tag/v2.10.2%2B0
We had to make two modifications to our tests to make them pass with the new resources:
v2.4.0v2.1.0and we also had to update two percy baselines to account for CSS changes.
I hope the instructions added in ff135bd will make this process accessible to other Dash.jl contributors in the future.