Callback context #46
Merged
Callback context #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -28,7 +28,7 @@ jobs: | |||
| - run: | |||
| name: 🔎 Unit tests | |||
| command: | | |||
| julia -e 'using Pkg; Pkg.update(); Pkg.add(PackageSpec(url="https://github.com/plotly/Dash.jl.git", rev=ENV["CIRCLE_BRANCH"])); Pkg.add(PackageSpec(url="https://github.com/waralex/dash-html-components.git", rev="jl_generator_test")); Pkg.add(PackageSpec(url="https://github.com/waralex/dash-core-components.git", rev="jl_generator_test")); Pkg.build("Dash"); Pkg.build("DashHtmlComponents"); Pkg.build("DashCoreComponents"); Pkg.test("Dash", coverage=true); function precompile_pkgs(); for pkg in collect(keys(Pkg.installed())); if !isdefined(Symbol(pkg), :Symbol) && pkg != "Compat.jl"; @info("Importing $(pkg)..."); try (@eval import $(Symbol(pkg))) catch end; end; end; end; precompile_pkgs()' | |||
| julia test/ci_prepare.jl | |||
There was a problem hiding this comment.
😎 🍹 Much nicer, thanks!
src/handler/callback_context.jl
Outdated
| outputs_list::Vector{Any} | ||
| inputs_list::Vector{Any} | ||
| states_list::Vector{Any} | ||
| triggered::Union{Nothing, Vector{TriggeredParam}} |
There was a problem hiding this comment.
Is the Nothing necessary? Won't triggered at least be a length-0 Vector? Just trying to make sure this is as easy to use as possible, so users don't need fallback code for the Nothing case.
There was a problem hiding this comment.
@alexcjohnson I agree, I'll fix it
There was a problem hiding this comment.
@alexcjohnson fixed at eb51d4b
src/handlers.jl
Outdated
| include("handler/router.jl") | ||
| include("handler/base.jl") | ||
| #include("handler/router.jl") | ||
| #include("handler/base.jl") |
There was a problem hiding this comment.
@alexcjohnson fixed at eb51d4b
alexcjohnson
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
callback_context()function. This function only works from callback processing functions and returns a CallbackContext object :In addition, I refactored the code structure - distributed independent parts of the code to different files, designed the routing-related functionality as a sub-module, and so on. Therefore, the number of changed files in PR turned out to be significant, but for the most part it is copying code from old files to new ones.