Skip to content

define line and area on mapbox [JS] #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 9, 2020
Merged

Conversation

Mahdis-z
Copy link
Contributor

@Mahdis-z Mahdis-z commented Sep 3, 2019

closes #1412

@nicolaskruchten
Copy link
Contributor

  • section/example headers need to be descriptive of the examples: less emphasis on tiles and tokens outside of the "layers" page
  • more explanatory text around "there are N ways to do this, here is how they compare, here are links to the other ways, here is one example of each"
  • Line and area should be separate pages
  • While we're at it we likely need "filled areas on maps" (non-mapbox)
  • Line: we should document the "broken line" trick
  • Area: we should document the "broken trace" trick and we should point out that there are basically three ways in Mapbox to make areas... fill-to-self, geojson layers, and the new choroplethmapbox trace type
  • for the non-mapbox case there is only the one way to make filled areas today.

note: let's start with the Python versions of these pages please

@nicolaskruchten
Copy link
Contributor

Please rebase onto s-d-m- to get CI up and running :)

@nicolaskruchten nicolaskruchten changed the title define line and area on mapbox define line and area on mapbox [JS] Sep 19, 2019
@Mahdis-z Mahdis-z removed the request for review from michaelbabyn September 19, 2019 19:44
@nicolaskruchten
Copy link
Contributor

Should match the permalinks and contents of plotly/plotly.py-docs#125

@nicolaskruchten nicolaskruchten merged commit b89a3b4 into source-design-merge Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.49 Mapbox features
2 participants