Clean-up towards a continuous deployment model #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use ggplotly branch as a 'stage' branch (following Toby's practices).
|
+1 |
mkcor
added a commit
that referenced
this pull request
May 7, 2014
Clean-up towards a continuous deployment model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Continuous deployment model: The code on the master branch is always tested and deployable. Any testing that needs to happen should be done on the feature branch before it's merged into master."
Now we have a conversion for
geom_barbut we should support more aesthetics than justfill(http://docs.ggplot2.org/current/geom_bar.html). Also, line 231 ofggplotly.Rshould be moved outside the for loop. Then we will be able to check offgeom_barin this list: issue #18 :)