Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for images endpoint #279

Merged
merged 4 commits into from
Sep 14, 2015
Merged

Add support for images endpoint #279

merged 4 commits into from
Sep 14, 2015

Conversation

cpsievert
Copy link
Collaborator

No description provided.

@cpsievert
Copy link
Collaborator Author

@chriddyp plotly_IMAGE() seems to work for me locally now. Since I'm mostly adding this to reduce overhead in our testing infrastructure, I'll go ahead and make those changes to testing in this pull request (unless you'd like it separated out in another PR).

@cpsievert
Copy link
Collaborator Author

@chriddyp this is ready for merging. It shouldn't change any existing functionality, it essentially just adds the plotly_IMAGES() function which should be useful for testing.

If we merge now, then I can assume master's HEAD has plotly_IMAGES(), which will make it easier to modify the test table build script to use the images endpoint.

@cpsievert
Copy link
Collaborator Author

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/80260522

On TravisCI, commit de951de was successfully merged with b0532b9 (master) to create d34e75f. A visual testing table comparing b0532b9 with d34e75f can be found here ->

http://cpsievert.github.io/plotly-test-table/R/d34e75f/

Detected 0 differences

cpsievert added a commit that referenced this pull request Sep 14, 2015
Add support for images endpoint
@cpsievert cpsievert merged commit 2a043c0 into master Sep 14, 2015
@cpsievert cpsievert deleted the images branch November 20, 2015 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant