Skip to content

Add crossline functionality #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

apalchys
Copy link
Contributor

@apalchys apalchys commented Nov 8, 2017

This PR adds showcrossline, crosslinecolor, crosslinethickness and crosslinedash axis config attributes.

Related to Issue #54

The purpose of the new attributes is to create a custom styled crossline for the corresponding axis.
The behavior of the crossline is similar to the behavior of the spikes feature, but there are several differences:

  • crosslines do not depend on the selected hovermode
  • crosslines are always drawn over the nearest x|y point, regardless of whether this point is within the max hover distance or not
  • crosslines are always drawn across the entire plot area

The crosslines are automatically switched off when the spikes are turned on on the same axis.

Only the cartesian type of axis supports crosslines.

Screenshots:
image

image

@etpinard
Copy link
Contributor

Thanks for the PR.

We haven't discussed adding a feature like this into the library before - so I can't really approve this PR.

Would you mind opening an issue to first start a discussion?

@etpinard
Copy link
Contributor

Closing until some consensus is reached in #2155

@etpinard etpinard closed this Nov 13, 2017
@bfmcneill
Copy link

This feature would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants