Skip to content

test case for bug #2765 #2966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test case for bug #2765 #2966

wants to merge 1 commit into from

Conversation

ErwanMAS
Copy link
Contributor

@ErwanMAS ErwanMAS commented Sep 3, 2018

test case for bug #2765
when gl-vis/regl-line2d#35 will be closed

By applying this patch i was able to run npm run test-image , and tests was good except 3 tests that was already failed before .

--- plotly.js/node_modules/regl-line2d/index.js.old	2018-09-02 20:27:03.000000000 -0400
+++ plotly.js/node_modules/regl-line2d/index.js.new	2018-09-02 20:26:53.000000000 -0400
@@ -689,7 +689,7 @@
 	}

 	// remove null items
-	this.passes = this.passes.filter(Boolean)
+//	this.passes = this.passes.filter(Boolean)

 	return this
 }

@etpinard etpinard changed the title test case for bug https://github.com/plotly/plotly.js/issues/2765 test case for bug #2765 Sep 4, 2018
@etpinard
Copy link
Contributor

etpinard commented Sep 4, 2018

Thanks for submitting us a PR!

I don't think we actually need a new mock to lock down a future fix for #2765 though. Updating mock gl2d_text_chart_single-string (which is currently missing a line for its data[2] trace) will suffice.

@etpinard
Copy link
Contributor

etpinard commented Sep 10, 2018

@ErwanMAS I'll close this PR.

Commit ee17d2e locks the fix for #2765 and your new mock in #2979 will be enough to lock your fill work.

Thanks again for your help!

@etpinard etpinard closed this Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants