Use Template.newContainer in polar axis defaults #3092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Note: does not need template propagation, since coerceAxis is still | ||
| // based on the subplot-wide coerce function. Though it may be more | ||
| // efficient to make a new coerce function, then we *would* need to | ||
| // propagate the template. |
There was a problem hiding this comment.
huh, so was this comment wrong all along, or did something change since I wrote this?
There was a problem hiding this comment.
That comment was only partially correct/wrong.
We didn't have to propagate the templates for attributes getting coerced by the coerce function in the polar/layout_defaults.js scope, but we do need to for attributes getting coerced by coerce2 like here:
plotly.js/src/plots/cartesian/line_grid_defaults.js
Lines 30 to 32 in 5c4094f
There was a problem hiding this comment.
but we do need to for attributes getting coerced by coerce2 like here
Ah... there it is, thanks.
|
Very nice. Regardless of the answer to my question, 💃 |
etpinard
added a commit
that referenced
this pull request
Oct 11, 2018
... Template.newContainer does that internally already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checking off the last item in #3055
cc @plotly/plotly_js