histogram2d fixes #3922
Merged
histogram2d fixes #3922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this fixes some shared histogram2d (via bingroup) edge cases - this fixes a performance regression from #3845
- this removed the annoying `x: NaN` from histogram2d hover labels
etpinard
commented
May 29, 2019
| @@ -232,8 +232,8 @@ function calcAllAutoBins(gd, trace, pa, mainData, _overlayEdgeCase) { | |||
|
|
|||
| // all but the first trace in this group has already been marked finished | |||
| // clear this flag, so next time we run calc we will run autobin again | |||
| if(trace._autoBinFinished) { | |||
| delete trace._autoBinFinished; | |||
| if(trace['_' + mainData + 'autoBinFinished']) { | |||
There was a problem hiding this comment.
Fixup from #3909
As now both histogram and histogram2d* traces go through calcAllAutoBins, we need to split the "has autoBin finished` logic into x and y values.
etpinard
commented
May 29, 2019
| @@ -0,0 +1,756 @@ | |||
| { | |||
| "data": [ | |||
There was a problem hiding this comment.
etpinard
commented
May 29, 2019
| @@ -0,0 +1,756 @@ | |||
| { | |||
| "data": [ | |||
There was a problem hiding this comment.
This one looks like:
on master.
|
Nicely done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@plotly/plotly_js This PR starts with a fix for #3909 then follow-up with two more
histogram2d*bug fixes.