Skip to content

Do not show tick labels falling inside rangebreaks #4696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Mar 27, 2020

Follow up of #4614 and #4684,
this PR fixes #4692 | demo: before vs after.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Mar 27, 2020
@archmoj archmoj added this to the v1.53.0 milestone Mar 27, 2020
@archmoj
Copy link
Contributor Author

archmoj commented Mar 27, 2020

TODO slack message from @alexcjohnson

"The thing to look out for in testing is whether, due to the rounding of the displayed value, we can get to a situation that the label shown actually corresponds to a situation past the first data point beyond the break. ie the label says Tuesday’s date but there are data points for Monday afternoon to the right of it.
With any luck that just won’t happen, even if we combine day of week and hour breaks, but that’s the key thing to test.

@alexcjohnson
Copy link
Collaborator

Out of the mocks here, the only one that bothers me is axes_breaks-night_autorange-reversed.png

Screen Shot 2020-03-27 at 2 58 17 PM

The "05:59" labels are weird, why don't they say "06:00"? But everything else is great, and even this one is more correct than before, just uglier. It's an obscure enough edge case that I'd be happy merging and releasing like this, and flagging this for follow-up later.

@archmoj
Copy link
Contributor Author

archmoj commented Mar 27, 2020

💃
Merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rangebreaks sometimes draws the gridline on the wrong point
2 participants