Skip to content

Fix npm ci for npm 6 users #6004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,23 @@ orbs:
# https://hub.docker.com/r/cimg/node/tags/

jobs:
install-and-cibuild:
install-and-cibuild-node12: # cibuild using node 12 & npm 6
docker:
- image: cimg/node:12.22.7
working_directory: ~/plotly.js
steps:
- checkout
- run:
name: Set up build environment
command: .circleci/env_build.sh
- run:
name: Pretest
command: npm run pretest
- run:
name: CI-Build
command: npm run cibuild

install-and-cibuild: # main cibuild using node 16 & npm 7
docker:
- image: cimg/node:16.8.0
working_directory: ~/plotly.js
Expand Down Expand Up @@ -370,6 +386,8 @@ workflows:
version: 2
build-and-test:
jobs:
- install-and-cibuild-node12

- install-and-cibuild
- timezone-jasmine:
requires:
Expand Down
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
stackgl_modules
node_modules
dist
build
Expand Down
Loading