-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
David/enhancement modebar #7429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
davidangarita1
wants to merge
16
commits into
plotly:master
Choose a base branch
from
geopozo:david/enhancement-modebar
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+36
−1,546,905
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
54d1253
Add role="toolbar" to enhance accessibility semantics
davidangarita1 318530e
Add tabindex="0" to buttons
davidangarita1 ebb7b12
Add custom CSS class "modebar--custom"
davidangarita1 8748342
Add aria label
davidangarita1 fd9ad69
Add modebar tabindex 0
davidangarita1 e2c6615
Add listener of Intro key for Modebar buttons
davidangarita1 a2fa286
Move button listener
davidangarita1 06d3d1f
Add style for focus in modebar
davidangarita1 e557ee1
Change "a" tag for "button" tag
davidangarita1 9386b15
Add styles for focus in button
davidangarita1 6dc49c9
Change the indentation to the correct format
davidangarita1 905cab1
Update build
davidangarita1 363a873
Fix scss indentation
davidangarita1 165dffe
Remove unnecessary js for the button
davidangarita1 904e64a
Fix indentation for spaces
davidangarita1 605c627
Merge remote-tracking branch 'origin/master' into david/enhancement-m…
davidangarita1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidangarita1 Could you re-add all these deleted files in
dist/
(or revert the commit that removed them)?That will make this PR easier to review.