Skip to content

Adding pointcloud #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 7, 2016
Merged

Adding pointcloud #850

merged 11 commits into from
Sep 7, 2016

Conversation

monfera
Copy link
Contributor

@monfera monfera commented Aug 12, 2016 •
edited
Loading

This PR contains the plotly.js part of the new pointcloud2d trace type.

Work left involves

  • changing certain things about sizing
  • removing some disused marker options
  • image test cases
  • npm publish gl-pointcloud2d

@monfera monfera force-pushed the pointcloud-squashed branch from db35191 to 98f90ad Compare August 12, 2016 15:33
etpinard
etpinard reviewed Aug 12, 2016
View reviewed changes
lib/index-gl2d.js
@@ -12,6 +12,7 @@ var Plotly = require('./core');

Plotly.register([
require('./scattergl'),
require('./pointcloud2d'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this pointcloud !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now done

@monfera monfera force-pushed the pointcloud-squashed branch from 98f90ad to 0deaccc Compare August 12, 2016 16:08
@etpinard etpinard added this to the v1.17.0 milestone Aug 12, 2016
@monfera monfera force-pushed the pointcloud-squashed branch from 553975d to b45d3d7 Compare August 15, 2016 15:05
@monfera monfera force-pushed the pointcloud-squashed branch 3 times, most recently from 1860058 to 2f1005f Compare September 1, 2016 17:27
etpinard
etpinard reviewed Sep 1, 2016
View reviewed changes
src/traces/pointcloud/attributes.js
module.exports = {
x: scatterglAttrs.x,
y: scatterglAttrs.y,
xy: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a dream come true

@etpinard
Copy link
Contributor

etpinard commented Sep 1, 2016 •
edited
Loading

@monfera Looks like the the autoscale and reset scale mode bar buttons don't work

gifrecord_2016-09-01_180432

I suspect that's caused by the doAutorange not finding all the required info.

We might want to have a look at 330c5f3

@etpinard
Copy link
Contributor

etpinard commented Sep 1, 2016

Apart from the above comment and a few naming / styling issues this PR is looking amazing.

@monfera Thanks for all your hard work!

@monfera
Copy link
Contributor Author

monfera commented Sep 1, 2016

@etpinard thanks for all your comments, they look easy, i.e. perfect for a morning ramp-up. Special thanks for catching this interaction issue too!

@monfera
Copy link
Contributor Author

monfera commented Sep 1, 2016

@etpinard I just wanted to mention that I had some unpushed commits in gl-gis/pointcloud-2d and the image now should come out like this (see the difference in the opacity, size and boundary).
image

@monfera monfera force-pushed the pointcloud-squashed branch from c3dcf7d to 138a6e0 Compare September 2, 2016 18:01
@etpinard etpinard removed this from the v1.17.0 milestone Sep 7, 2016
@monfera monfera force-pushed the pointcloud-squashed branch from 138a6e0 to b1da4c0 Compare September 7, 2016 17:04
@monfera monfera force-pushed the pointcloud-squashed branch from b1da4c0 to 16f7fd5 Compare September 7, 2016 17:23
@monfera
Copy link
Contributor Author

monfera commented Sep 7, 2016

@etpinard for the record the solution to the plot disappearance issue on +/-/reset you found is here in stackgl: stackgl/gl-shader#16 - thanks again for catching it!

@etpinard etpinard added this to the v1.17.0 milestone Sep 7, 2016
@monfera monfera changed the title [WIP] adding point cloud Adding pointcloud Sep 7, 2016
etpinard
etpinard reviewed Sep 7, 2016
View reviewed changes
src/traces/pointcloud/convert.js
if(xy) {

positions = xy;
len = xy.length >>> 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bitwise ops are cool 😎 but can you add a short comment above describing what this does (for folks unfamiliar with them).

etpinard
etpinard reviewed Sep 7, 2016
View reviewed changes
src/traces/pointcloud/convert.js
@@ -96,6 +96,8 @@ proto.updateFast = function(options) {
if(xy) {

positions = xy;

// dividing xy.length by 2 and truncating to integer if xy.length was not even
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much!

@monfera monfera force-pushed the pointcloud-squashed branch from 954845f to 8105955 Compare September 7, 2016 20:03
@etpinard
Copy link
Contributor

etpinard commented Sep 7, 2016

Amazing work 💃

@etpinard etpinard merged commit 06af109 into plotly:master Sep 7, 2016
This was referenced Sep 7, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature something new
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@monfera @etpinard @rreusser @cldougl