4x iplot load-time performance #182
Merged
+3
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every _repr_* method that exists is called on instantiation of a IPython.core.display.HTML subclass. For Plotly, _repr_png, _repr_svg, _repr_jpeg require a call to the image server to generate the image. Combined, the 4 requests can make iplot commands take 4 times as long as usual. We mistakenly thought that the _repr_ commands were only called on demand, e.g. on a call to `nbconvert`. Unfortunately, this removes our support for `nbconvert`. An upcoming PR with cached images should bring this support back.
|
These tests are failing: https://github.com/plotly/python-api/blob/master/plotly/tests/test_optional/test_ipython/test_embed.py#L30-62 You can probably just remove them. We can go back in the commit history and snag them again if we reimplement. I opened up an issue in ipython about this: ipython/ipython#7573 |
skip image tests (we’re removing these methods for now)
chriddyp
added a commit
that referenced
this pull request
Jan 27, 2015
4x iplot load-time performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @theengineear