Ipyplotly test fixes #974
Closed
Ipyplotly test fixes #974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New codegen logic in codegen/ New datatype classes generated into plotly/datatypes/ (These are gitignored) New validator classes generated into plotly/validators/ (These are gitignored) Code generation in update_graph_objs.py modified to map Figure, Layout, and Trace types to new plotly/datatypes/ classes. All other classes mapped to raw dicts/lists.
It's now possible to execute a fair amount of legacy graph construction and plotting code
TODO: add support for datetime arrays in validation and in widget serialization
Added js/ directory containing front-end widget library Added graph_objs.FigureWidget class that maps to datatypes.FigureWidget
These are mostly just for discussion during the WIP integration process.
|
@chriddyp @jmmease |
chriddyp
reviewed
Mar 15, 2018
| @@ -0,0 +1,27 @@ | |||
| *.egg-info/ | |||
There was a problem hiding this comment.
@Kully - It looks like you committed a lot of extra stuff, like this ipyplotly folder. Was that intentional? If not, could you rebase and open up a new PR?
There was a problem hiding this comment.
I highly recommend using a git client like GitHub desktop https://desktop.github.com/ to make your commits - it makes a lot easier to view what you will commit before committing it, as well as organizing your commits to only include certain files and line numbers
There was a problem hiding this comment.
It was intentional. ipyplotlycan't be located without the folder in ploty.py
|
Also, could you make the PR against the original PR instead of |
|
Closing in favor of #975 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix minor test failures in #942