Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

fix_label_facets #164

Closed
wants to merge 1 commit into from
Closed

fix_label_facets #164

wants to merge 1 commit into from

Conversation

harisbal
Copy link

@harisbal harisbal commented Dec 2, 2019

At the moment labels do not get applied to the titles of facets.
This PR fixes this.

@harisbal harisbal closed this Dec 2, 2019
@harisbal harisbal reopened this Dec 2, 2019
@harisbal
Copy link
Author

harisbal commented Dec 2, 2019

It's just a very minor modification , I can't understand why the PR is rejected..

@nicolaskruchten
Copy link
Contributor

The files in this repo have all been moved into the Plotly.py repository actually, since July. If you’ve found an bug with the latest version, I would recommend opening an issue first to discuss it :)

@nicolaskruchten
Copy link
Contributor

I suspect the issue you’re trying to address exists in the latest version as well actually: https://github.com/plotly/plotly.py/blob/49e39b13f7b93652ad1c0ea07726cc79efd69872/packages/python/plotly/plotly/express/_core.py#L1285

If you would like to open a PR in that repo I’ll happily review it there! Ideally with a test case as well if possible please :)

@harisbal
Copy link
Author

harisbal commented Dec 3, 2019

Thanks @nicolaskruchten
I forgot plotly_express merged with plotly. Cheers

@nicolaskruchten
Copy link
Contributor

OK I've reproduced and logged it here: plotly/plotly.py#1944

If you want to submit a PR in the other repo we'd appreciate it, otherwise we'll try to fix it for the next release ;)

@nicolaskruchten
Copy link
Contributor

Thanks for bringing this to our attention!

@harisbal
Copy link
Author

harisbal commented Dec 3, 2019

I'll give it a go, it seems quite trivial. Thanks for preparing the example.

@nicolaskruchten
Copy link
Contributor

We're prepping for a release so I went ahead: plotly/plotly.py#1966 :)

@harisbal
Copy link
Author

harisbal commented Dec 3, 2019

Sorry I couldn't pull this off earlier.
Nice addition, thanks

@emmanuelle
Copy link
Contributor

Thank you @harisbal !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants