-
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
It's just a very minor modification , I can't understand why the PR is rejected.. |
The files in this repo have all been moved into the Plotly.py repository actually, since July. If you’ve found an bug with the latest version, I would recommend opening an issue first to discuss it :) |
I suspect the issue you’re trying to address exists in the latest version as well actually: https://github.com/plotly/plotly.py/blob/49e39b13f7b93652ad1c0ea07726cc79efd69872/packages/python/plotly/plotly/express/_core.py#L1285 If you would like to open a PR in that repo I’ll happily review it there! Ideally with a test case as well if possible please :) |
Thanks @nicolaskruchten |
OK I've reproduced and logged it here: plotly/plotly.py#1944 If you want to submit a PR in the other repo we'd appreciate it, otherwise we'll try to fix it for the next release ;) |
Thanks for bringing this to our attention! |
I'll give it a go, it seems quite trivial. Thanks for preparing the example. |
We're prepping for a release so I went ahead: plotly/plotly.py#1966 :) |
Sorry I couldn't pull this off earlier. |
Thank you @harisbal ! |
At the moment labels do not get applied to the titles of facets.
This PR fixes this.