Skip to content

Package upgrades; babel 6 -> 7 #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2019
Merged

Package upgrades; babel 6 -> 7 #127

merged 1 commit into from
Feb 21, 2019

Conversation

dmt0
Copy link
Contributor

@dmt0 dmt0 commented Feb 21, 2019 •
edited
Loading

Update all packages, including babel 6->7

Minified/uglified file output in /dist dir went from 23,284 bytes to 23,856 bytes. I guess nobody promised us a smaller file from using Babel 7 😐

@dmt0 dmt0 requested a review from bpostlethwaite February 21, 2019 06:30
@dmt0
Copy link
Contributor Author

dmt0 commented Feb 21, 2019

@bpostlethwaite ready for review

bpostlethwaite
bpostlethwaite approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@bpostlethwaite bpostlethwaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, no one did promise that :)
Bundle size increases in JS is the one of the Standard Model constants
💃

@dmt0 dmt0 merged commit df8fb07 into master Feb 21, 2019
@dmt0 dmt0 deleted the babel7 branch February 21, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpostlethwaite bpostlethwaite bpostlethwaite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmt0 @bpostlethwaite