Voxels, Coordinates, and Generalized perspective transform #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… geometric correction.
The use of these is not consistent throughout DarSIA yet.
…in matrix indexing.
…ing on coordinates and voxels.
… in same resolution as the input image.
|
For completeness, the test coverage and documentation coverage for the introduced functionality is satisfactory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A native implementation of a general perspective transform is provided whcih concatenates standard perspective transforms, bulge and stretch operations. These are the standard routines entering
CurvatureCorrection.The implementation is based on a newly introduced concept of
VoxelandCoordinateas well asVoxelArrayandCoordinateArray. These are subclasses ofnp.ndarraybut explicitly carry the information of how to understand these. In addition, the types are used in the transformation routines ofCoordinateSystem. This in part addresses Issue #265 .The graphical assistants also make use of the new point characterizations.
However, not alle objects employ the new objects instead of standard numpy arrays.