Bedrock 1.26.10#342
Conversation
![pmmp-admin-bot[bot]](https://avatars.githubusercontent.com/in/1059952?s=60&v=4){kind=small}
| $cache = array_flip(self::EASE_TYPE_NAMES); | ||
| } | ||
|
|
||
| return $cache[$name] ?? throw new \InvalidArgumentException("Invalid raw value \"$name\" for EaseType."); |
There was a problem hiding this comment.
This should use PacketDecodeException
There was a problem hiding this comment.
Actually I may be wrong on this one. Depends if it's used during a decode handler or not. If it is, we don't want to be throwing random exceptions since it'll crash
| $value = []; | ||
| for($i = 0; $i < 4; ++$i){ | ||
| $value[] = LE::readUnsignedInt($in); | ||
| } |
There was a problem hiding this comment.
Probably better to just read these as separate vars - better for serialize/deserialize symmetry analysis that way
|
|
||
| class ClientboundDataDrivenUICloseAllScreensPacket extends DataPacket implements ClientboundPacket{ | ||
| public const NETWORK_ID = ProtocolInfo::CLIENTBOUND_DATA_DRIVEN_UI_CLOSE_ALL_SCREENS_PACKET; | ||
| class ResourcePacksReadyForValidationPacket extends DataPacket{ |
There was a problem hiding this comment.
Is this clientbound or serverbound?
| use pmmp\encoding\LE; | ||
| use pocketmine\network\mcpe\protocol\serializer\CommonTypes; | ||
|
|
||
| class ServerboundDataDrivenScreenClosedPacket extends DataPacket{ |
There was a problem hiding this comment.
This should implement ServerboundPacket
| use pocketmine\network\mcpe\protocol\types\SyncWorldClocksRemoveTimeMarker; | ||
| use pocketmine\network\mcpe\protocol\types\SyncWorldClocksSyncState; | ||
|
|
||
| class SyncWorldClocksPacket extends DataPacket{ |
There was a problem hiding this comment.
Missing clientbound/serverbound interface
| use pocketmine\network\mcpe\protocol\types\AttributeUpdateLayers; | ||
| use pocketmine\network\mcpe\protocol\types\AttributeUpdateLayerSettings; | ||
|
|
||
| class ClientboundAttributeLayerSyncPacket extends DataPacket{ |
There was a problem hiding this comment.
This should implement ClientboundPacket
| use pocketmine\network\mcpe\protocol\types\LocatorBarWaypointPayload; | ||
| use function count; | ||
|
|
||
| class LocatorBarPacket extends DataPacket{ |
There was a problem hiding this comment.
Missing clientbound/serverbound
| use pmmp\encoding\ByteBufferWriter; | ||
| use pocketmine\network\mcpe\protocol\serializer\CommonTypes; | ||
|
|
||
| class PartyChangedPacket extends DataPacket{ |
There was a problem hiding this comment.
Missing clientbound/serverbound
2 participants
No description provided.