Assemble 1.21.40 #6471
Merged
Assemble 1.21.40 #6471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocketmine/bedrock-data & pocketmine/bedrock-protocol still have to be tagged
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dktapps
requested changes
Oct 24, 2024
dktapps
reviewed
Oct 24, 2024
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
... |
ShockedPlot7560
previously approved these changes
Oct 25, 2024
We need a second approval before we can merge, this is a security feature. |
|
looks good? |
Yes, I think it is, but there is no one to do the review, so it takes time, I think. |
|
There are still unaddressed review comments |
dktapps
added
Category: Protocol
What else does he have to change? |
dries-c
dismissed stale reviews from ShockedPlot7560 and github-actions[bot]
via
25857c3
dktapps
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR updates PM5 to 1.21.40
Changes
Backwards compatibility
See pmmp/BedrockProtocol#277