[libpng18] [code cleanup] Remove 10700 checkes where possible. #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes certain of the 10700 checks which can safely be removed as they depend on the major require in libpng-1.7 which is not happening in libpng-1.8. The checks in pngvalid.c remain because it may (should) be possible to fix or partially the underlying libpng bugs in 1.8. The checks document what those bugs are and ideally the 10700 branch of the #if's can be used after a fix. Signed-off-by: John Bowler <[email protected]>
jbowler
changed the title
ctruta
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes certain of the 10700 checks which can safely be removed as
they depend on the major require in libpng-1.7 which is not happening
in libpng-1.8.
The checks in pngvalid.c remain because it may (should) be possible to
fix or partially the underlying libpng bugs in 1.8. The checks document
what those bugs are and ideally the 10700 branch of the #if's can be
used after a fix.
Signed-off-by: John Bowler [email protected]