build: Move the pnglibconf files and scripts to scripts/pnglibconf/ #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Considering that pnglibconf is a whole mini-system for configuring and building libpng, it should be placed in its own dedicated subdirectory. Any future additions, including tests and documentation, should go into this subdirectory. One exception: pnglibconf.h.prebuilt is moved to the top-level source directory, where pnglibconf.h would be. This follows the organization pattern typically used with the "*.in" files, for example. All references to the pnglibconf artifacts, found in machine-readable code and in human-readable comments, are updated accordingly.
|
I forgot to mention in the commit message one more thing that I did: while editing the libpng manual, I also corrected some of the phrasing and formatting in the surrounding paragraphs. In any case, the manual needs a heavy facelift. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jbowler please review.
Just so you know, after this change, the next fossil that I want to discard is the .DEF file and all the associated makefile-ing and scripting. We should neither produce it (with pnglibconf or not), nor consume it in any makefile or build file or project file any further. We should rather go back to using
__declspec(dllexport)where applicable (i.e. on Windows), or__attribute__((visibility("default")))where applicable (on the Unix platforms with the compilers that allow it), which is what we used to use from libpng-1.0 to libpng-1.4, except with one important difference: no more .DEF file.