JOSS review response summary#94
Merged
Merged
Conversation
leijerry888
changed the title
Fix relative imports
|
Sorry for the late reply. The first g36 notebook works as expected and is, indeed, helpful. |
|
My comments look properly addressed |
Collaborator
Author
Thank you @lazlop again for your review and valuable feedback! |
This was referenced Feb 13, 2026
Closed
Closed
Closed
Closed
fix tspr demo bug
lymereJ
added a commit
that referenced
this pull request
Feb 13, 2026
leijerry888
marked this pull request as ready for review
April 7, 2026 07:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR summarizes responses to feedback provided by JOSS reviewers. It contains the following PRs:
#91 update brick related guide document
#92 update GUI and GUI doc
#93 address all other documentation related comments
#95 address json element name related comments
#97 address coding style related comments
#100 refactor demo
PR addressing reviewer comments that has already been merged in develop:
#90 separate dev and user environment requirements
PR addressing reviewer comments that are specific to the white paper, thus are merging to paper branch:
#96 paper revisions