Merge pull request IQSS#11136 from vera/fix/9200-allowmultiples-for-d…

…eep-nesting

fix: correctly set "multiValued" property in Solr schema for deeply nested fields

doc/release-notes/11136-solr-nested.md

@@ -0,0 +1 @@
+Deeply nested metadata fields are not supported but the code used to generate the Solr schema has been adjusted to support them. See #11136.

src/main/java/edu/harvard/iq/dataverse/DatasetFieldType.java

@@ -541,17 +541,26 @@ public SolrField getSolrField() {
                 solrType = SolrField.SolrType.FLOAT;
             }
 
-            Boolean parentAllowsMultiplesBoolean = false;
-            if (isHasParent()) {
-                if (getParentDatasetFieldType() != null) {
-                    DatasetFieldType parent = getParentDatasetFieldType();
-                    parentAllowsMultiplesBoolean = parent.isAllowMultiples();
+            Boolean anyParentAllowsMultiplesBoolean = false;
+            DatasetFieldType currentDatasetFieldType = this;
+            // Traverse up through all parents of dataset field type
+            // If any one of them allows multiples, this child's Solr field must be multi-valued
+            while (currentDatasetFieldType.isHasParent()) {
+                if (currentDatasetFieldType.getParentDatasetFieldType() != null) {
+                    DatasetFieldType parent = currentDatasetFieldType.getParentDatasetFieldType();
+                    if (parent.isAllowMultiples()) {
+                        anyParentAllowsMultiplesBoolean = true;
+                        break; // no need to keep traversing
+                    }
+                    currentDatasetFieldType = parent;
+                } else {
+                    break;
                 }
             }
 
             boolean makeSolrFieldMultivalued;
             // http://stackoverflow.com/questions/5800762/what-is-the-use-of-multivalued-field-type-in-solr
-            if (allowMultiples || parentAllowsMultiplesBoolean || isControlledVocabulary()) {
+            if (allowMultiples || anyParentAllowsMultiplesBoolean || isControlledVocabulary()) {
                 makeSolrFieldMultivalued = true;
             } else {
                 makeSolrFieldMultivalued = false;