[Building Sync-ups Tutorial] fixes in "Testing the sync-up detail" chapter #3579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify tutorial introduction to accurately describe how the SyncUpDetail feature updates parent state using a shared property
Refactor test code to: - Use `modify` for nested state updates - Apply `withLock` for thread-safe state mutation when editing a sync-up
…Shared` property.
Since it is already tested in the navigation section, I finally remove it and update the tutorial text to inform of that with a link to it.
FredericRuaudel
commented
Feb 2, 2025
| Let's start by testing the edit flow. We will exercise the full user flow of tapping the | ||
| Let's write a test for the edit flow. We will exercise the full user flow of tapping the |
There was a problem hiding this comment.
📓 I've slightly changed this intro which were implying this is the first section of several which is not the case anymore.
FredericRuaudel
commented
Feb 2, 2025
Comment on lines
71
to
73
|
|
||
| As for the delete flow, since it involves its parent feature and some navigation with the dismiss | ||
| helper, we'll test it later in the <doc:TestingNavigation>. |
There was a problem hiding this comment.
📓 I've mention and link to the delete flow testing being now in the navigation testing chapter
...re/Documentation.docc/Tutorials/BuildingSyncUps/06-SyncUpDetail/TestingSyncUpDetail.tutorial
Outdated
Show resolved
Hide resolved
…ildingSyncUps/06-SyncUpDetail/TestingSyncUpDetail.tutorial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Following my last PR, I'm currently reviewing the "Building Sync-ups" tutorial and so far, there is a lot of changes so I've splitted up into one PR per chapter to ease the review of them, continuing with the "Testing the sync-up detail" chapter here…
Changes Made:
modifyfunction for nested state updates, fixing errors explained in Getter for 'subscript(dynamicMember:)' is unavailable Xcode16 #3158. Additionally, thewithLockfunction has been implemented to fix the associated compilation errors.@Sharedproperty, that was left for a future update I guess. Here again, I've tried my best to fit your tones and vocabulary in the explanation but feel free to update the copyrighting as you see fit 🙂