Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Building Sync-ups Tutorial] fixes in "Navigating to sync-up detail" chapter #3581

Merged

Conversation

FredericRuaudel
Copy link
Contributor

Hi!

Following my last PR, I'm currently reviewing the "Building Sync-ups" tutorial and so far, there is a lot of changes so I've splitted up into one PR per chapter to ease the review of them, continuing with the "Navigating to sync-up detail" chapter here…

Changes Made:

  • CardView Update: The CardView component has been updated to utilize foregroundStyle instead of the deprecated foregroundColor.
  • Refactoring for Compilation Errors:
    • In SyncUps view encapsulate the shared collection within an Array in the ForEach loop.
    • In navigation tests, encapsulate the sharedSyncUp within a Shared structure.
    • Path manipulation has been updated to utilize case-based access.
    • Modify syncUps list using withLock.

…rrors

- Encapsulate `sharedSyncUp` with `Shared`.
- Update path manipulation to use case-based 
access. 
- Update `syncUps` list with locking mechanism.
…ildingSyncUps/07-SyncUpDetailNavigation/SyncUpDetailNavigation.tutorial
Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@stephencelis stephencelis merged commit 6d55b5c into pointfreeco:main Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants