Skip to content

Attempt to fix aws/ec2 with :filters parameter #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Attempt to fix aws/ec2 with :filters parameter #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion request.lisp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@
append (to-query-params k v)))
(loop for i from 1
for v in value
collect (cons (format nil "~A.member.~A" key i) v))))
append (to-query-params (format nil "~A.member.~A" key i)
(aws-sdk/generator/shape::input-params v)))))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, tried this, (though my quicklisp dist of aws-sdk is apparently behind the version edited here). I now get as far as making the request but get a 400 response saying "The parameter Filters is not recognized".

This is on the stack, may indicate the malformed request. Not having done much at the request level I can't say if it's valid, though I'm thinking it's supposed to be Filter.N, not Filter.member.N.

#<QURI.URI.HTTP:URI-HTTPS https://ec2.us-east-1.amazonaws.com/?Action=DescribeInstances&Version=2016-11-15&Filters.member.1.Name=tag%3AName&Filters.member.1.Values.member.1=dev-19587>

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeInstances.html - though I haven't checked if that is the version being used by aws-sdk

(boolean
(list (cons key
(if value
Expand Down