Reply to all review comments

proto/poktroll/service/tx.proto

@@ -44,9 +44,9 @@ message MsgUpdateParamsResponse {}
 // permissionless.
 // TODO_BETA: Add Champions / Sources once its fully defined.
 message MsgAddService {
-  option (cosmos.msg.v1.signer) = "address"; // https://docs.cosmos.network/main/build/building-modules/messages-and-queries
-  string address = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"]; // The Bech32 address of the service supplier using cosmos' ScalarDescriptor
-  poktroll.shared.Service service = 2 [(gogoproto.nullable) = false]; // The Service for which the supplier is adding to the network
+  option (cosmos.msg.v1.signer) = "owner_address"; // https://docs.cosmos.network/main/build/building-modules/messages-and-queries
+  string owner_address = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"]; // The Bech32 address of the service owner using cosmos' ScalarDescriptor
+  poktroll.shared.Service service = 2 [(gogoproto.nullable) = false]; // The Service being added to the network
 }
 
 message MsgAddServiceResponse {}

proto/poktroll/shared/tx.proto

@@ -13,7 +13,7 @@ option go_package = "github.com/pokt-network/poktroll/x/shared/types";
 // Msg defines the Msg service.
 service Msg {
   option (cosmos.msg.v1.service) = true;
-  
+
   // UpdateParams defines a (governance) operation for updating the module
   // parameters. The authority defaults to the x/gov module account.
   rpc UpdateParams (MsgUpdateParams) returns (MsgUpdateParamsResponse);
@@ -23,12 +23,12 @@ service Msg {
 message MsgUpdateParams {
   option (cosmos.msg.v1.signer) =                         "authority";
   option           (amino.name) = "poktroll/x/shared/MsgUpdateParams";
-  
+
   // authority is the address that controls the module (defaults to x/gov unless overwritten).
   string authority = 1 [(cosmos_proto.scalar) = "cosmos.AddressString"];
 
   // params defines the module parameters to update.
-  
+
   // NOTE: All parameters must be supplied.
   Params params = 2 [(gogoproto.nullable) = false, (amino.dont_omitempty) = true];
 }

x/service/keeper/msg_server_add_service.go

@@ -41,23 +41,23 @@ func (k msgServer) AddService(
 	foundService, found := k.GetService(ctx, msg.Service.Id)
 	if found {
 		if foundService.OwnerAddress != msg.Service.OwnerAddress {
-			logger.Error(fmt.Sprintf("Owner address of existing service (%q) does not match the owner address %q", foundService.OwnerAddress, msg.Address))
+			logger.Error(fmt.Sprintf("Owner address of existing service (%q) does not match the owner address %q", foundService.OwnerAddress, msg.OwnerAddress))
 			return nil, types.ErrServiceInvalidOwnerAddress.Wrapf(
 				"existing owner address %q does not match the new owner address %q",
 				foundService.OwnerAddress, msg.Service.OwnerAddress,
 			)
 		}
 		return nil, types.ErrServiceAlreadyExists.Wrapf(
-			"TODO: Don't have for updating existing service ID: %s", msg.Service.Id,
+			"TODO(@adshmh): This is an ephemeral state of the code. Once we s/AddService/UpdateService/g, add the business logic here for updates here.",
 		)
 	}
 
 	// Retrieve the address of the actor adding the service; the owner of the service.
-	serviceOwnerAddr, err := sdk.AccAddressFromBech32(msg.Address)
+	serviceOwnerAddr, err := sdk.AccAddressFromBech32(msg.OwnerAddress)
 	if err != nil {
-		logger.Error(fmt.Sprintf("could not parse address %s", msg.Address))
+		logger.Error(fmt.Sprintf("could not parse address %s", msg.OwnerAddress))
 		return nil, types.ErrServiceInvalidAddress.Wrapf(
-			"%s is not in Bech32 format", msg.Address,
+			"%s is not in Bech32 format", msg.OwnerAddress,
 		)
 	}